Fix Vault.logical.read NoMethodError on HTTP 204 responses - #386
Merged
Conversation
When Vault responds with HTTP 204 (No Content), the client.get() method returns nil. Previously, this nil was passed directly to Secret.decode(), which attempted to call .each on nil, resulting in a NoMethodError. This commonly occurred when reading from PKI engines without configured certificates, or any other endpoint that legitimately returns 204 No Content. Now Vault.logical.read() returns nil when the response is empty, consistent with its behavior for 404 responses. Fixes #241
beekus
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Vault responds with HTTP 204 (No Content), the client.get() method returns nil. Previously, this nil was passed directly to Secret.decode(), which attempted to call .each on nil, resulting in a NoMethodError.
This commonly occurred when reading from PKI engines without configured certificates, or any other endpoint that legitimately returns 204 No Content.
Now Vault.logical.read() returns nil when the response is empty, consistent with its behavior for 404 responses.
Fixes #241